Skip to content

Adapt to latest standards#227

Merged
mschwoer merged 12 commits intodevelopmentfrom
adapt_to_latest_standards
Mar 12, 2025
Merged

Adapt to latest standards#227
mschwoer merged 12 commits intodevelopmentfrom
adapt_to_latest_standards

Conversation

@mschwoer
Copy link
Copy Markdown
Contributor

@mschwoer mschwoer commented Jan 23, 2025

see individual commit ..
next step would be to get rid of development branch, okay @jalew188 ?

edit:
apparently, for Mac-x64, torch=2.5.1 is not available: https://github.com/MannLabs/alphapeptdeep/actions/runs/12938838760/job/36089916306
how shall we deal with it? @jalew188 @GeorgWa

  • pin the version to a working number just for that architecture? -> would solve the issue for installers, but pypi install of stable would still not work for that architecture

@mschwoer mschwoer requested a review from jalew188 January 23, 2025 22:01
@mschwoer mschwoer marked this pull request as ready for review January 23, 2025 22:01
@mschwoer mschwoer requested a review from GeorgWa January 28, 2025 09:24
Copy link
Copy Markdown
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jalew188
Copy link
Copy Markdown
Collaborator

edit: apparently, for Mac-x64, torch=2.5.1 is not available: https://github.com/MannLabs/alphapeptdeep/actions/runs/12938838760/job/36089916306 how shall we deal with it? @jalew188 @GeorgWa

  • pin the version to a working number just for that architecture? -> would solve the issue for installers, but pypi install of stable would still not work for that architecture

Just use the latest that is available for all platforms?

@mschwoer
Copy link
Copy Markdown
Contributor Author

Just use the latest that is available for all platforms?
hm, but then in case torch will never be released again for mac-x64, this will block us from updating that dependency

Base automatically changed from adapt_to_new_alphabase to development February 18, 2025 14:03
@mschwoer
Copy link
Copy Markdown
Contributor Author

pinned torch to the latest version for macos/x64 -> https://github.com/MannLabs/alphapeptdeep/actions/runs/13811759485/job/38634817969

@mschwoer mschwoer merged commit ab79cc8 into development Mar 12, 2025
2 checks passed
@mschwoer mschwoer deleted the adapt_to_latest_standards branch March 12, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants